-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
png.decode callback function #14
Comments
Bump! Just ran into this myself, thanks for raising it. |
Yes, totally true, this library is not usable as is because of this, because it throws exceptions from nowhere |
Any chance of this being fixed - or is this npm abandoned ? Any good alternatives ? |
Haven't found any better alternatitves personally ... |
I'm now using pngjs rather than png-js |
I'm using https://github.com/devongovett/png-stream these days. |
If you have made a new, better library, what about deleting this one from Github? |
It shouldn't be deleted from github, but it would be good to show a deprecated sign and link to the new png-stream repository |
When you search for "png javascript" on Github, this is the first result. Many people start using it without noticing, that author "does not care" about this library for quite a long time. Right now, I need to decode PNGs with palettes for my app https://www.Photopea.com and can't find a good library. Many good JS libs are made to work inside Node.js only. I think these bindings are completely unnecessary . |
The callback function for png.decode should have two arguments. The first should be for handling an error, the second should be the image data.
As it stands, if an image is loaded for a file which does not exist, the cryptic crash happens:
The text was updated successfully, but these errors were encountered: