Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not open setting tab on extension update events #3

Open
pravj opened this issue Aug 30, 2019 · 1 comment
Open

Do not open setting tab on extension update events #3

pravj opened this issue Aug 30, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pravj
Copy link
Member

pravj commented Aug 30, 2019

Context
As per the current implementation (check the background script), the settings tab is opened on every onInstalled event.

Problem
It results in behavior where the tab is opened on every extension version update as well as the first installation event, which is unnecessary.

Solution
The enhanced implementation can validate using the local-storage if the extension is set up (user-access-token) or not. If the extension is activated, it can ignore the onInstalled event.

@pravj pravj added enhancement New feature or request good first issue Good for newcomers labels Aug 30, 2019
@jerone
Copy link

jerone commented Jan 26, 2020

[..] where the tab is opened on every extension version update as well as the first installation event [..]

And for some reason, also opened on every Firefox update.

Every time I see the settings page, I think something is wrong with the configuration of this extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants