Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN New Architecture #397

Open
va1bhav opened this issue Dec 31, 2024 · 1 comment
Open

RN New Architecture #397

va1bhav opened this issue Dec 31, 2024 · 1 comment

Comments

@va1bhav
Copy link

va1bhav commented Dec 31, 2024

Hi @bhariharan @wmathurin,
For one of our applications we wanted to enable New Architecture in RN however SF SDK v 12.2 had some challenges with it. So, we tried to work with SF SDK 12.2 and RN 0.76(considering SDK still uses RN 0.74).

Now we have only one issue

Android works ok,
IOS version builds ok, however there is one bug that pops up when signing in to SF. App crashes in completion clause in this part of the code:

[SFSDKAuthHelper loginIfRequired:^{
[self setupRootViewController];
}];

[self setupRootViewController] refreshes IOS view whenever users logs in or logs out, but it simply doesn't work here. We can comment it out, but then app needs to be killed and reopened.

We tried various solutions to this problem:

• dispatch_async
• delays
• using other methods from SFSDKAuthHelper

but it didn't help. Errors are for example like:

react_native_assert failure: link_.status != Status::Running && "Surface must not be running."
Assertion failed: (link_.status != Status::Running && "Surface must not be running."), function setUIManager, file SurfaceHandler.cpp, line 318.

We tried patching parts of react native code as suggested in facebook/react-native#48213, but no success so far.

The combination of React Native / SF SDK is not compatibile at the moment, as 12.2 requires React Native 0.74 and not 0.76. However, there were compatibility problems with libraries in 0.74 (like react-native-gesture-handler in new architecture requires 0.75), so we had the most success with 0.76.

So question,
Is there a tentative timeline when New version of SF SDK compatible with RN 0.76 is supposed to be released?
Will SDK v13 use RN 0.76?

Also, just in case you have faced this issue with upgrading SDK v13 to latest RN, is there probably a different way of setting the library up in AppDelegate.m which we can try?

@wmathurin
Copy link
Contributor

Mobile SDK 12.2 has been tested and confirmed to work with React Native 0.74.5. While we haven’t yet finalized plans, we hope to upgrade the React Native dependency in Mobile SDK 13.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants