Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to componentRunner #53

Open
jeswin opened this issue Apr 20, 2022 · 4 comments
Open

Migrate tests to componentRunner #53

jeswin opened this issue Apr 20, 2022 · 4 comments
Labels
low-priority Low Priority

Comments

@jeswin
Copy link
Member

jeswin commented Apr 20, 2022

Component Runner based tests are cleaner, and easier to write.
We should migrate the old tests.

@jeswin jeswin added the low-priority Low Priority label Apr 20, 2022
@spiffytech
Copy link
Member

I can work on tests from the bottom of the alphabet upwards, if you want to go the other direction.

@jeswin
Copy link
Member Author

jeswin commented Apr 21, 2022

Yeah sounds good.

Would you rate this as higher priority compared to the performance work? The performance work could be useful from a "marketing" standpoint as well. Accompanied by a clickbaity "We made forgo 5x faster with this simple trick". (No, I'm not planning to do that.)

@spiffytech
Copy link
Member

My thought is perf would be a big win. I know I've looked at several frameworks just because I noticed them scoring well on that benchmark, and even modest rankings improvements are a nice confidence booster for prospective users.

Hopefully we spot some quick wins, and I'd say those would be the priority. That would naturally involve touching some existing tests, which can be migrated as we go.

After the quick wins, anything else might wind up happening in stages, and we can't judge priority on that until we've assessed possible gains. Tests migrations can be done incrementally too, so a tick-tock rhythm might be appropriate here.

@spiffytech
Copy link
Member

I've got a WIP branch where I'm converting everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low-priority Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants