Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing SHA-256= prefix in Digest header for request signing #44

Open
pengux opened this issue Dec 4, 2020 · 0 comments
Open

Missing SHA-256= prefix in Digest header for request signing #44

pengux opened this issue Dec 4, 2020 · 0 comments

Comments

@pengux
Copy link
Contributor

pengux commented Dec 4, 2020

The documentation states that the digest header should have the SHA-256= prefix. Although the code in Kong doesn't actually uses the value from the header in the request so the bug doesn't seem to trigger any error.

https://api-docs.form3.tech/tutorial-request-signing.html
https://github.com/form3tech-oss/go-form3/blob/master/pkg/form3/auth_request_signing.go#L98
https://github.com/form3tech/docker-kong/blob/develop/kong/form3-signer/handler.lua#L172

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant