Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests that pass but contain only commented out code #706

Open
Tracked by #713
eureka-cpu opened this issue Dec 4, 2023 · 0 comments
Open
Tracked by #713

Remove tests that pass but contain only commented out code #706

eureka-cpu opened this issue Dec 4, 2023 · 0 comments
Labels
code quality Improvements to code to meet standards good first issue Good for newcomers

Comments

@eureka-cpu
Copy link
Contributor

eureka-cpu commented Dec 4, 2023

Some tests don't assert anything and therefore may be passing when in fact they test nothing. These can be removed, and if they become necessary we can add more thorough testing in the future. Use caution, make sure the test isn't mistakenly commented out, or is a correctly passing test. If so, open an issue to handle that test case.

@eureka-cpu eureka-cpu added good first issue Good for newcomers code quality Improvements to code to meet standards labels Dec 4, 2023
@eureka-cpu eureka-cpu added this to the org: cleanup milestone Dec 4, 2023
@eureka-cpu eureka-cpu mentioned this issue Dec 5, 2023
27 tasks
@eureka-cpu eureka-cpu removed this from the org: cleanup milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvements to code to meet standards good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant