Add Contract Test CLI #749
Conversation
…emintal block_height
… in test_contract
There was a problem hiding this comment.
Are we planning on adding other functions/ops besides transfer soon? If we're coming back to that beyond the next couple of weeks, we might want to replace the todo!() macro call with something more helpful to the user like an eprintln!() telling them that the function they specified isn't supported yet.
This all looks pretty good and the hard work is much appreciated.
|
|
||
| Ok(()) | ||
| } | ||
| // #716 This JSON string is a placeholder to allow the code to compile. What we need to do is |
There was a problem hiding this comment.
Which JSON string? Or is this an old comment?
There was a problem hiding this comment.
Yes, I could work on adding in the other Erc20 function inputs besides transfer, went ahead and replace the todo(). & that was an old comment, I removed it as well as other ones I found redundant 👍
There was a problem hiding this comment.
Looks good. Thanks. I want to merge this into main so that we have it, but if we do that, it's not going to compile. I'm having to rewrite large parts of the versatus-rust package and it's going to break what you have here. If we merge this in, we'll need to do so in a way that won't break the build. In C, I'd just wrap it all in #ifdefs, but not sure of a Rusticle way to do that. Or we could keep it in a branch til we see what the versatus-rust crate looks like and work on a plan for updating this to suit the new stuff. Maybe @eureka-cpu also has some ideas and thoughts here. We're definitely going to make use of what you have here, but I don't think you should be put under the same arbitrary deadline that the rest of us are :D
Closes #716