Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about generated routing table #17

Closed
ileneruth opened this issue Oct 4, 2022 · 5 comments · Fixed by #18
Closed

Question about generated routing table #17

ileneruth opened this issue Oct 4, 2022 · 5 comments · Fixed by #18
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@ileneruth
Copy link

I notice that a routing table is created in vpc.tf, but it's not bound to any subnets and doesn't have any rules. What is the intended purpose of this routing table?

@Joel-Cripps Joel-Cripps self-assigned this Oct 5, 2022
@Joel-Cripps
Copy link
Member

Hey Ilene, I believe this is just a vestige from the original, we no longer have that section in the HA version.
@fshuva can you remove that in the next release?

@Joel-Cripps Joel-Cripps added bug Something isn't working enhancement New feature or request labels Oct 5, 2022
@ileneruth
Copy link
Author

Thanks @Joel-Cripps . I think this terraform still backs the single instance IBM catalog offering - I assume it's still ok to use, even though the HA is there as well?

@Joel-Cripps
Copy link
Member

Yes of course. HA is a separate repo. If you are looking for a CLI/local based terraform deploy you can check out our other repos here: https://github.com/fortinet/fortigate-terraform-deploy/tree/main/ibm

@ileneruth
Copy link
Author

Ah ok, thanks for the link - I may switch over. I'm incorporating the terraform into a larger 'landing zone'. I've forked this repository (https://github.com/ibmcloud-tech-canada/ibm-fortigate-terraform-deploy) and made some updates, like ensuring all resources land in a resource group, and I have another update coming that takes a customer provided key to encrypt the boot and data volumes. I also had to remove the provider block to use as a module in a larger script.

@Joel-Cripps
Copy link
Member

Sounds good. PR's are welcome if you want to send some of the changes this way. Otherwise when you have finished send us the link and maybe we can incorporate some of the changes. Customer provided keys to encrypt would be a useful addition for sure.

@fshuva fshuva linked a pull request Oct 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants