Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexInventory is not built to respect async/await requests #26

Open
JesseStimpson opened this issue Oct 23, 2024 · 0 comments
Open

IndexInventory is not built to respect async/await requests #26

JesseStimpson opened this issue Oct 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@JesseStimpson
Copy link
Collaborator

IndexInventory was implemented before async/await functions on the Repo, and it should be revisited. For example querying the IndexInventory happens both on a get_by and an async_get_by. If there is no cached entry, then a wait must occur before the QueryPlan. This cannot be changed. However, if there is already a cached entry, then a wait happens to check the correctness of the cache entry against the active schema version. I think this wait can be optimistically deferred via the Future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant