Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvement to the score track #41

Open
foxfriends opened this issue Jan 26, 2021 · 5 comments
Open

UI improvement to the score track #41

foxfriends opened this issue Jan 26, 2021 · 5 comments
Assignees
Labels
frontend Requires updating the frontend (JS/Svelte) code

Comments

@foxfriends
Copy link
Owner

foxfriends commented Jan 26, 2021

The score track is able to show scores, but there are some improvements that could be made mostly regarding how multiple players on the same space are displayed.

Since the pieces are stacked, simulated using box-shadows, piece elements are added and removed from the DOM when they enter/leave spaces with other tiles already on them. Also when multiple pieces are on the same space, you cannot tell which players they are other than the top one.

Pieces on the score track should always be displayed as distinct pieces, even when stacked, by moving them vertically and layering with z-index as appropriate. When a stack of pieces are moused over, they should spread out so you can see all the pieces below.

Additionally, the current player's score should always be the top tile when stacked. Currently, it is whatever faction happens to be first in the stack.

@foxfriends foxfriends added the frontend Requires updating the frontend (JS/Svelte) code label Jan 26, 2021
@agdust
Copy link
Collaborator

agdust commented Feb 8, 2021

I will take care of the score track, but maybe better to make it like UI, not like the board part? Because now player has to scroll down map and hover on track to get all info about scores.

I really don't like current info board that rolls from right on hover, maybe we can put almost all info on screen without even hovering

Here is the basic concept of my vision of this info, what do you think about it?
image

@agdust agdust self-assigned this Feb 8, 2021
@foxfriends
Copy link
Owner Author

I will take care of the score track, but maybe better to make it like UI, not like the board part? Because now player has to scroll down map and hover on track to get all info about scores.

Hmm yes this is a good point. I think it would be best to keep it on the score track (otherwise the score track is empty) but also having it in a proper spot on the UI would be good!

I really don't like current info board that rolls from right on hover, maybe we can put almost all info on screen without even hovering

This is a good point too... Very possible it could go somewhere else that is better looking yes. The one there is a placeholder still (note the very blue background), I was thinking it would have the decks and small version of each player board visible when collapsed and you can open it on each player to view things. Could be opened by click instead of hover, that is fine. Yours looks like it is just the same thing but on the other side and flipped upside down, maybe I am misunderstanding it?

I will make a separate ticket for that you can do if you like.

@agdust
Copy link
Collaborator

agdust commented Feb 8, 2021

Well, it's not only about moving to right. The idea is just to make field more "solid" to feel:

  1. There is only one main thing -- map (now screen is splitted)
  2. Nothing is flashing on hover, only clicks (also mobile-friendly)
  3. All data is in your view (card count in decks, scores, turn, etc.) -- it means we have several buttons and all info is in different dialogs, not in one big board

Did you play the Root in steam? I think its UI is pretty good, except of some little things

@foxfriends
Copy link
Owner Author

Ok sounds good! You can work on that too if you like.

I didn't play the Steam one no, looks nice though. Makes me wonder why I bother building this one at all haha it didn't exist long ago when I started this project the first time.

@agdust agdust linked a pull request Feb 9, 2021 that will close this issue
@foxfriends foxfriends removed a link to a pull request Feb 9, 2021
@foxfriends
Copy link
Owner Author

Reopening for now, I feel like something is still missing. We can revisit when players are able to score points normally

@foxfriends foxfriends reopened this Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires updating the frontend (JS/Svelte) code
Projects
None yet
Development

No branches or pull requests

2 participants