Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parts of the asset map that use session storage #130

Open
smcalilly opened this issue Feb 17, 2022 · 0 comments
Open

Improve parts of the asset map that use session storage #130

smcalilly opened this issue Feb 17, 2022 · 0 comments

Comments

@smcalilly
Copy link
Contributor

smcalilly commented Feb 17, 2022

Some weird UX. The parts of state that are in session storage will remain when the user returns to that page and they haven't interacted in a while (if they're still using the same browser tab). The "assets successfully saved" message was still there after I had been updating a phase in the phase form and then returned to the map to add assets. The previous search was still there, too.

I think this could be fixed if we fetched the local assets via ajax after saving them, rather than reloading the entire page (which reloads the map and table with the newly saved assets.) We could then do away with session storage because the react component wouldn't reload and thus the state would remain. We would still have their search in the state and could do a more ephemeral success/error message that didn't rely on session storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant