Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some fields in Popup class to internal API #63

Open
AlexShukel opened this issue Jun 20, 2022 · 0 comments
Open

Move some fields in Popup class to internal API #63

AlexShukel opened this issue Jun 20, 2022 · 0 comments
Assignees
@AlexShukel
Labels
breaking-changes Changes that are breaking previous functionality invalid This doesn't seem right

Comments

@AlexShukel
Copy link
Collaborator

setCloseHandler, PopupComponent, props, popupIdentifier should not be in public API. In fact, only close function must be exported.
@AlexShukel AlexShukel added invalid This doesn't seem right breaking-changes Changes that are breaking previous functionality labels Jun 20, 2022
@AlexShukel AlexShukel self-assigned this Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexShukel AlexShukel

Labels
breaking-changes Changes that are breaking previous functionality invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AlexShukel