Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix masked-loading when using two channels in cellpose task. #640

Closed
tcompa opened this issue Jan 17, 2024 · 1 comment · Fixed by #639
Closed

Fix masked-loading when using two channels in cellpose task. #640

tcompa opened this issue Jan 17, 2024 · 1 comment · Fixed by #639
Labels
bug Something isn't working

Comments

@tcompa
Copy link
Collaborator

tcompa commented Jan 17, 2024

The original code could only work with one channel input for masking the background. This commit adds support for more than one channel.
(#639 (comment))

Thanks @FranziskaMoos-FMI for the PR!

I'll try to add a failing test first, so that #639 can then fix it.
@tcompa tcompa added the bug Something isn't working label Jan 17, 2024
@tcompa tcompa mentioned this issue Jan 18, 2024
Closed
@tcompa tcompa linked a pull request Jan 18, 2024 that will close this issue
[DO NOT MERGE] Add test_workflow_secondary_labeling_two_channels #642
Closed
tcompa added a commit to franziskamoos/fractal-tasks-core that referenced this issue Jan 18, 2024
@tcompa
Add test_workflow_secondary_labeling_two_channels for issue fractal…
d29cb89 
…-analytics-platform#640
@tcompa tcompa mentioned this issue Jan 18, 2024
Merged
1 task
@tcompa
Copy link
Collaborator Author

tcompa commented Jan 18, 2024

The CI in #642 fails, while the same (new) test passes within #639.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@tcompa