Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking ROI tables should use the labels as index of the table as well #672

Open
jluethi opened this issue Apr 1, 2024 · 0 comments
Open

Comments

@jluethi
Copy link
Collaborator

jluethi commented Apr 1, 2024

Masking ROI tables have an table.obs that contains a label column. That table does also have an index though and the index is 0-based. That makes for confusion e.g. in the ROI loader, when the name of a ROI (classically the index of .obs is used as the ROI names for other ROI tables) does not match the ROI label.

Easiest solution: Also make the index of that table the label value.

Current state:

>>> table.obs
   label
0      1
1      2
2      3
3      4
4      5
5      6
6      7
7      8
8      9
9     10
10    11

Target: Index & label column match

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant