Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass distDir and buildCommand to framer-plugin-tools package #90

Open
andirsun opened this issue Oct 23, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@andirsun
Copy link

andirsun commented Oct 23, 2024

Describe the bug
We are creating a Plugin inside a NX mono-repo, where the folder structure is something like this

apps/
  another-app/
  my-plugin/ (This is my plugin code)
dist/
 apps/
   another-app/
   my-plugin/ (This is the directory of my compiled plugin files)
package.json (main package.json shared for all projects)

The problem is that the package framer-plugin-tools you recomend to package the compiled files into a ZIP is not receiving any parameters and in our case we should be able to modify

  • distDir: The default distDir ir const distPath = path.join(process.cwd(), "dist") but in our project the distDir should be dist/my-plugin/

  • buildCommand: the default build command is const buildProcess = exec("npm run build") but in our project is reserved to compile all projects, so we should be able to pass npm run build:my-plugin

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@andirsun andirsun added the bug Something isn't working label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant