Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drain shutdown event #5

Merged
merged 1 commit into from
Feb 3, 2025
Merged

fix: Drain shutdown event #5

merged 1 commit into from
Feb 3, 2025

Conversation

ankush
Copy link
Member

@ankush ankush commented Feb 3, 2025

Otherwise it goes in a spinny loop. The flag numbers were also wrong, as per https://man7.org/linux/man-pages/man2/eventfd.2.html

The file descriptor is readable (the select(2) readfds argument; the poll(2) POLLIN flag) if the counter has a value greater than 0.

AND

If EFD_SEMAPHORE was not specified and the eventfd counter has a nonzero value, then a read(2) returns 8 bytes containing that value, and the counter's value is reset to zero.

Otherwise it goes in a spinny loop
@ankush ankush merged commit b9a8570 into frappe:master Feb 3, 2025
12 of 13 checks passed
@ankush ankush deleted the fix-shutdown branch February 3, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant