Feature/fault correction rate #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 23, 2021 22:25
…nhofer-iem/dodo-database-service into feature/FaultCorrectionRate
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done the calculation based on the logic provided. However, In my opinion, there is something missing while calculating
{ open_bugs = issues[ label = bug, state = open, created_at <= release.created_at ] }. Either there should be a created_at >= release.previous().created_at or the open bugs value will be more than expected.
That is why i have provided a break; statement at line 722. Can you please check that segment of code. Also if the logic provided in the KPI documentation is correct. Thanks :)