Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add recipe ingredient converter workshop #57153

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: add recipe ingredient converter workshop #57153

wants to merge 8 commits into from

Conversation

naomi-lgbt
Copy link
Member

Checklist:

Closes freeCodeCamp/CurriculumExpansion#650

@github-actions github-actions bot added scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: i18n language translation/internationalization. Often combined with language type label labels Nov 14, 2024
@naomi-lgbt naomi-lgbt marked this pull request as ready for review November 15, 2024 01:28
@naomi-lgbt naomi-lgbt requested a review from a team as a code owner November 15, 2024 01:28
jdwilkin4
jdwilkin4 reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@jdwilkin4 jdwilkin4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of small comments but otherwise looks great 💯

client/i18n/locales/english/intro.json Outdated Show resolved Hide resolved
...sh/25-front-end-development/workshop-recipe-ingredient-converter/67351754cc06dc00d4661745.md Outdated Show resolved Hide resolved
@jdwilkin4 jdwilkin4 added the full stack cert This label is for the new full stack certification label Nov 15, 2024
@jdwilkin4 jdwilkin4 added the status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending. label Nov 15, 2024
@moT01 moT01 self-assigned this Nov 15, 2024
moT01
moT01 reviewed Nov 15, 2024
View reviewed changes
Copy link
Member

@moT01 moT01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good @naomi-lgbt 👍 Pretty fun - found one typo. I noticed one other issue - I don't think you can make some of those conversions without knowing more about the ingredient. From volume to mass, for instance - cups and teaspoons are volume, and grams and ounces are mass I think. So if I want to convert 2 cups of something, I can convert it to teaspoons, because they're both volume. But I cannot convert 2 cups of something to grams without know the weight of that thing. 2 cups of water might 400 grams, but 2 cups of flour might be 200 grams.

Just mentioning it. I think we're fine to go with it like this for now.

...sh/25-front-end-development/workshop-recipe-ingredient-converter/67351754cc06dc00d4661745.md Outdated Show resolved Hide resolved
@Dario-DC
Copy link
Contributor

Dario-DC commented Nov 18, 2024 •
edited
Loading

So if I want to convert 2 cups of something, I can convert it to teaspoons, because they're both volume. But I cannot convert 2 cups of something to grams without know the weight of that thing. 2 cups of water might 400 grams, but 2 cups of flour might be 200 grams.

Do we want to introduce the density? Otherwise I would mention that these conversions refer to a density of 1 g/mL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moT01 moT01 moT01 left review comments

@jdwilkin4 jdwilkin4 jdwilkin4 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@moT01 moT01

Labels
full stack cert This label is for the new full stack certification platform: learn UI side of the client application that needs familiarity with React, Gatsby etc. scope: curriculum Lessons, Challenges, Projects and other Curricular Content in curriculum directory. scope: i18n language translation/internationalization. Often combined with language type label status: waiting review To be applied to PR's that are ready for QA, especially when additional review is pending.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add recipe converter functional programming workshop to main repo
4 participants
@naomi-lgbt @Dario-DC @moT01 @jdwilkin4