Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in function recompileExceptionClearForArm #308

Open
cr4zyserb opened this issue Jan 30, 2024 · 0 comments
Open

bug in function recompileExceptionClearForArm #308

cr4zyserb opened this issue Jan 30, 2024 · 0 comments

Comments

@cr4zyserb
Copy link
Contributor

There is a small logic issue in recompileExceptionClearForArm as when there is end of block, and relocator.readOne(); returns 0, it will throw exception, while it should break

    do {
      const offset = relocator.readOne();
      if (offset === 0) {
        throw new Error('Unexpected end of block');
      }

it should be:

    do {
      const offset = relocator.readOne();
      if (offset === 0) {
        break;
      }

As same logic is followed in recompileExceptionClearForArm64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant