Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documenation is not updated with the changes in v 0.6.0 #154

Open
LiamPClancy opened this issue Sep 30, 2023 · 2 comments
Open

documenation is not updated with the changes in v 0.6.0 #154

LiamPClancy opened this issue Sep 30, 2023 · 2 comments
Milestone

Comments

@LiamPClancy
Copy link
Contributor

Not sure how the readme file is generated?

but it's still showing the old process for adding lines on crates.io

and I can see in the repo the readme file still has

let line1 = Line { points: points1, is_closed: true, has_fill: true, has_stroke: true, is_clipping_path: false, };

and

current_layer.add_shape(line1);

but after upgrading to v0.6.0

it should be

let line1 = Line { points: points1, is_closed: true };

current_layer.add_line(line1);

assuming there might be other issues in the old file as well.

if it just needs manualy copying and pasting from the relevant files, i'm happy to make a PR,
but thought i'd ask first incase it's build step that isn't running?

@fschutt
Copy link
Owner

fschutt commented Sep 30, 2023

It's not auto-generated, I need to update the README. I split the Line into Line and Polygon to make a distinction, so things like has_fill is useless.

@fschutt
Copy link
Owner

fschutt commented Nov 2, 2024

Need to update docs for 0.8.

@fschutt fschutt added this to the 0.8 milestone Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants