Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint should ignore "node_modules" by default #1137

Open
jamesponddotco opened this issue Feb 1, 2025 · 1 comment
Open

lint should ignore "node_modules" by default #1137

jamesponddotco opened this issue Feb 1, 2025 · 1 comment

Comments

@jamesponddotco
Copy link

jamesponddotco commented Feb 1, 2025

Right now it's impossible to lint some projects locally because lint will always fail if the project includes a node_modules directory, which the user can't and shouldn't edit.

Since a --ignore flag can't be added as it defeats the purpose of the tool, I believe some common directories and files should be ignored by default, such as the nodule_modules directory or the .DS_Store file on macOS.

@jamesponddotco jamesponddotco changed the title lint should ignore "node_modules" lint should ignore "node_modules" by default Feb 1, 2025
@aschrijver
Copy link

I thought that .gitignore was supposed to be honored, and just found that it is not for node_modules/ and even the old **/node_modules. In my monorepo top-level node_modules is ignored, but on a deeper package I get error:

The following files have no copyright and licensing information:
* packages/components/node_modules/.bin/astro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants