Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to leave mailing list in dashboard #584

Open
jeriox opened this issue Jul 29, 2024 · 6 comments
Open

Add button to leave mailing list in dashboard #584

jeriox opened this issue Jul 29, 2024 · 6 comments
Labels
mailing lists Concerning tenca / mailing list management [P] minor [T] functionality

Comments

@jeriox
Copy link
Contributor

jeriox commented Jul 29, 2024

In the list dashboard, a user can click on the name of a list that they are a member of, which takes them to the (un)subscribe view with their mail address prefilled. This is a bit confusing as a unsubscribe flow. As a user, I want the box of a mailing list to have a "unsubscribe" button that unsubscribes me directly.

@jeriox jeriox added [P] minor [T] functionality mailing lists Concerning tenca / mailing list management labels Jul 29, 2024
@lukasrad02
Copy link
Contributor

Since our students have two email addresses (short and long form) and the dashboard lists subscriptions for both variants, clicking the unsubscribe button should also cancel subscriptions for both variants if they are present.

Otherwise, there might still be an active subscription after clicking the button.

@SilvanVerhoeven
Copy link
Collaborator

Could you clarify: Are users still allowed to subscribe/unsubscribe with custom email addresses? If so, how would the system know which email address(es) the unsubscribe button should relate to?

@lukasrad02
Copy link
Contributor

The button proposed here should only be visible on the lists dashboard, which is, in turn, only accessible for logged-in users. Hence, we could derive the email address(es) from the account information.

If people (no matter whether they have an HPI account or not) subscribe non-HPI addresses to a mailing list, we cannot associate that subscription with an account. In this case, they would still have to use the unsubscribe link and enter their email address manually.

@jeriox
Copy link
Contributor Author

jeriox commented Jul 30, 2024

Could you clarify: Are users still allowed to subscribe/unsubscribe with custom email addresses? If so, how would the system know which email address(es) the unsubscribe button should relate to?

They are. But the list dashboard only contains mailing lists that you are a member of with your HPI address. So clicking the button would unsubscribe your HPI address.

Toggling the membership via the distribution link will not be affected by this.

@SilvanVerhoeven
Copy link
Collaborator

Does myHPI have access to all my email addresses (@student.hpi.de and @student.hpi.uni-potsdam.de) to iterate over them or does this need to be hard coded?

@lukasrad02
Copy link
Contributor

This is already hardcoded (https://github.com/fsr-de/myHPI/blob/main/myhpi/settings.py#L307C1-L310C2), the HPI IdP only exposes the primary email address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mailing lists Concerning tenca / mailing list management [P] minor [T] functionality
Development

No branches or pull requests

3 participants