From 294dd47cb8231f3fab922c4b2d9c8d060918961b Mon Sep 17 00:00:00 2001 From: Henning Meyer Date: Wed, 20 Dec 2023 21:36:42 +0100 Subject: [PATCH] Add test to agree on desired aligned behavior of ls for empty directories. --- gcsfs/tests/test_core.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gcsfs/tests/test_core.py b/gcsfs/tests/test_core.py index 1415d66f..48593255 100644 --- a/gcsfs/tests/test_core.py +++ b/gcsfs/tests/test_core.py @@ -163,7 +163,9 @@ def test_pickle(gcs): gcs.touch(a) assert gcs.ls(TEST_BUCKET) == gcs2.ls(TEST_BUCKET) - +# DO NOT MERGE! +# Note: We assume this test will fail. Once it does in CI, we will update the code to make it pass. +# Only then can this PR be approved and merged. def test_ls_touch(gcs): assert not gcs.exists(TEST_BUCKET + "/tmp/test") @@ -177,6 +179,11 @@ def test_ls_touch(gcs): assert {d["name"] for d in L_d} == {a, b} +def test_ls_empty_dir(gcs): + gcs.mkdir(TEST_BUCKET + "/test") + assert gcs.ls(TEST_BUCKET + "/test", False) == [] + + def test_rm(gcs): assert not gcs.exists(a) gcs.touch(a)