Add visual regression testing #57
Comments
aendra-rininsland
pushed a commit
that referenced
this issue
Mar 27, 2018
aendra-rininsland
pushed a commit
that referenced
this issue
Mar 28, 2018
aendra-rininsland
pushed a commit
that referenced
this issue
Apr 26, 2018
* Adds visual regression testing. Fixes #57. * Adding chartframe to tests * Specifying g-axis version from unpkg to avoid timeout * Removing build step from test script * Updating tests * Reducing the amount of boilerplates for regression tests * Adding more regression tests * Updating tests after chatting with @bobhaslett * Setting 20s timeout; @todo create local dep bundle for tests * Adding some exception handling to env * Fixing Docker on CI * Forgot no-sandbox * Downgrading to Node 8 * Trying with antialiasing on * Erugh, forgot to revert circle.yml * Now with fonts 🎉 * Does waiting until network idle help with fonts? * OH SO I GUESS I NEED TO USE NETWORKIDLE2 THEN THAT TOTES MAKES SENSE * Uhhh, networkidle0? * Let's try waiting 2s * Last try this week * Updating snapshots * Let's try this on OS X * 9.0? * No workdir? * Updating snapshot and env * Trying with antialiasing off * Trying to remove Metric locally * Updating thresholds * percent * Reverting to Linux * lint * More reverting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Beyond the unit tests mentioned in #35, we really should have some sort of tool set up to do visual regression testing as that will probably be the obvious way to notice regressive bugs.
Adding this would allow us to experiment with g-axis a bit more without having to worry so much about breaking existing functionality.
The text was updated successfully, but these errors were encountered: