Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Awareness for building a PR (security) #26

Open
joonas-fi opened this issue Feb 7, 2019 · 1 comment
Open

Awareness for building a PR (security) #26

joonas-fi opened this issue Feb 7, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@joonas-fi
Copy link
Member

joonas-fi commented Feb 7, 2019 •
edited
Loading

Currently some builds fail if publishing-related ENV var secrets are missing.

We should have awareness that we are building a PR (currently --publish-artefacts is hardcoded in the .travis.yml), and in those cases publishing-related ENV var secrets should be considered optional (because we should not even try to publish artefacts with PRs)
@joonas-fi joonas-fi mentioned this issue Feb 7, 2019
Merged
@joonas-fi joonas-fi added the enhancement New feature or request label Mar 7, 2020
@joonas-fi
Copy link
Member Author

Foundation work started in ab7a0be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joonas-fi