Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safety: don't allow built-in client to accidentally communicate with a non-related instance #226

Open
joonas-fi opened this issue Apr 17, 2023 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@joonas-fi
Copy link
Member

joonas-fi commented Apr 17, 2023

Problem

I was wondering why I see in logs my test server instance connecting to my production instance.

The issue is that some server components (e.g. mediascanner) also act as client.

I spun up a test server on the same machine where I have a client configured to connect to the production instance.

Hence my production server accidentally acted as a client not to itself, but to the production server.

Solution

Maybe have some sort of cluster ID which is stored in the client config file. Then when reading the client config file, assert that the server and the client cluster IDs match?

See also: "lineage" in Terraform: https://developer.hashicorp.com/terraform/language/state/backends#manual-state-pull-push

@joonas-fi joonas-fi added the enhancement New feature or request label Apr 17, 2023
@joonas-fi joonas-fi changed the title Safety: don't allow built-in client to accidentally communicate with a different instance Safety: don't allow built-in client to accidentally communicate with a non-related instance Apr 17, 2023
@joonas-fi joonas-fi added this to the current milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant