Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When buying an album, 1st line is always written in USD #810

Open
nicoalto opened this issue Aug 17, 2024 · 6 comments
Open

When buying an album, 1st line is always written in USD #810

nicoalto opened this issue Aug 17, 2024 · 6 comments
Labels
bug Something isn't working needs reproduce

Comments

@nicoalto
Copy link

Hi,

When buying an album, the 1st line price is always written in USD, even though the artist is in another currency (EUR, etc.) For example my artist page is in EUR, but 1st line is shown in USD and only below EUR. Doing the maths shows that both prices seem to be in EUR (93% of 5 EUR = 4,65 EUR). Same issue with a Canadian artist showing USD/CAD. Is this a bug?

Thanks!
Nicolas

Capture d’écran 2024-08-17 112157
Example link: https://mirlo.space/nicolas-hussein/release/compositions-vocales

@simonv3
Copy link
Collaborator

simonv3 commented Aug 19, 2024

Hmm, yeah this does feel like a bug. What's making it more curious is that it's showing up as euros for me:

image

similarly the sam nabi album is listed as CAD for me but shows up as USD in #816

@simonv3 simonv3 added the bug Something isn't working label Aug 19, 2024
@simonv3
Copy link
Collaborator

simonv3 commented Aug 21, 2024

Okay I think what's going on here is that the currency defaults to USD as display if it is missing from the information. I'm thinking of removing the currency default on the money renderer component and hopefully that fixes it?

simonv3 pushed a commit that referenced this issue Aug 21, 2024
@simonv3
Copy link
Collaborator

simonv3 commented Sep 13, 2024

gonna mark it as fixed, lmk if you're still seeing it

@simonv3 simonv3 closed this as completed Sep 13, 2024
@nicoalto
Copy link
Author

Still seeing it today...
Capture d’écran 2024-09-14 130023

@simonv3 simonv3 reopened this Sep 15, 2024
@simonv3
Copy link
Collaborator

simonv3 commented Oct 4, 2024

@nicoalto wondering if this is a caching issue--are you seeing this in private mode too?

@nicoalto
Copy link
Author

nicoalto commented Oct 5, 2024

Hi, yes I see this too in Firefox private mode...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs reproduce
Projects
None yet
Development

No branches or pull requests

2 participants