Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate task template from containing option references without a corresponding option #11

Open
irvinlim opened this issue Mar 25, 2022 · 1 comment
Open

Validate task template from containing option references without a corresponding option #11

irvinlim opened this issue Mar 25, 2022 · 1 comment
Labels
area/api Related to public APIs, including CRD design, configuration, etc component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature.

Comments

@irvinlim
Copy link
Member

The JobConfig's task template may contain a reference to ${option.xyz} even though the xyz option is not defined in the OptionSpec. This is most likely an error on the user's part, so we can fail validation at this point.
@irvinlim irvinlim added good first issue Good for newcomers area/api Related to public APIs, including CRD design, configuration, etc component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) labels Mar 25, 2022
@irvinlim
Copy link
Member Author

Pending decision on #47, put on hold first.

@irvinlim irvinlim added kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature. and removed good first issue Good for newcomers labels Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api Related to public APIs, including CRD design, configuration, etc component/execution Issues or PRs related exclusively to the Execution component (Job, JobConfig) kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@irvinlim