From b6d9943468751c2888fbe8ad942c28bcaa340924 Mon Sep 17 00:00:00 2001 From: Farid Zakaria Date: Fri, 24 Jan 2025 10:47:45 -0800 Subject: [PATCH] Do not include default javacopts rules_java already includes the toolchain's default javacopts when compiling java_library. Please see: https://github.com/bazelbuild/rules_java/blob/f26a240c3392f0ae45a2ce3244c93713d7539611/java/common/rules/java_toolchain.bzl#L167 fixes #1685 --- scala/private/rule_impls.bzl | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/scala/private/rule_impls.bzl b/scala/private/rule_impls.bzl index 35bf3032e..81e4c5ed4 100644 --- a/scala/private/rule_impls.bzl +++ b/scala/private/rule_impls.bzl @@ -157,10 +157,7 @@ def compile_java(ctx, source_jars, source_files, output, extra_javac_opts, provi output = output, javac_opts = expand_location( ctx, - extra_javac_opts + - java_common.default_javac_opts( - java_toolchain = java_toolchain, - ), + extra_javac_opts ), deps = providers_of_dependencies, #exports can be empty since the manually created provider exposes exports