Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin does play alerts incorrectly #8

Open
GloriousEggroll opened this issue Nov 24, 2024 · 4 comments
Open

plugin does play alerts incorrectly #8

GloriousEggroll opened this issue Nov 24, 2024 · 4 comments

Comments

@GloriousEggroll
Copy link
Contributor

GloriousEggroll commented Nov 24, 2024

if using the plugin for something like twitch alerts via streamlabs it breaks.

what I expect:

animated gif alert to fade in while playing the gif, then fade out.

what happens:

animated gif alert plays then hangs on the image instead of exiting

note: same alert works correctly in cef based obs-browser

@GloriousEggroll GloriousEggroll changed the title does not loop alerts correctly plugin does play alerts correctly Nov 24, 2024
@fzwoch
Copy link
Owner

fzwoch commented Nov 24, 2024

IS that any specific one?

Last time I tried it worked fine. But I cannot remember if it was streamlabs or some other alert provider.. But I guess it was streamlabs.. with the default alert (as I'm not really familiar with all the providers/options).

@fzwoch
Copy link
Owner

fzwoch commented Nov 24, 2024

I can confirm the issue.

@fzwoch
Copy link
Owner

fzwoch commented Nov 24, 2024

image

This may be a regression from cairo/webkitgtk? It seems like the surface buffer gets incorrectly swapped or not cleared between frames. (See ghosting like image of the zombie)

@fzwoch fzwoch changed the title plugin does play alerts correctly plugin does play alerts incorrectly Dec 9, 2024
@fzwoch
Copy link
Owner

fzwoch commented Jan 13, 2025

It seems to be caused by the WEBKIT_HARDWARE_ACCELERATION_POLICY_NEVER flag. When not rendering into an offscreen window but a regular window the artifacts are the same. Removing the flag so hardware acceleration is being used fixes the rendering. It is not possible to so in the context of this plugin though.

So I guess the error is in the software fallback in webkitgtk/gtk/cairo. Or maybe something completely different I haven't understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants