Skip to content
This repository has been archived by the owner on Jan 28, 2018. It is now read-only.

Misinformation in the "Python library usage" documentation section #2

Open
RomanMeR opened this issue Mar 3, 2017 · 2 comments
Open

Comments

@RomanMeR
Copy link

RomanMeR commented Mar 3, 2017

Hello gaetano-guerriero, today I just started using pypjlink and found out that command line utility works fine for my Vivitek projector, but when I tried using Python library, it raises assert in the protocol.py, in the parse_response function, on the "assert header == '%'" line. After spending some time I understood that the difference between command line interface and the way I used library is that CLI calls "authenticate" method on Projector instance before issuing command requested by user. But the "Python library usage" section in documentation both on GitHub and PyPi says nothing about this. So it would be great to fix the "Python library usage" documentation section and mention the "authenticate" call in it.

@ozel
Copy link

ozel commented Apr 18, 2017

thank's for writing this down. I can confirm the behaviour you describe with a Mitsubishi projector. Calling of .authenticate() is needed always, even if no password is set.

@Gummibeer
Copy link

I've opened a PR #3 to fix this and some other small issues in the readme.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants