Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main function to install script to not execute half-retrieved scripts #34

Open
vsund opened this issue Jul 30, 2018 · 0 comments
Open
Assignees

Comments

@vsund
Copy link
Contributor

vsund commented Jul 30, 2018

curl xyz | bash executes commands as they arrive. If there's a network error Bash might execute a half-retrieved script (which obviously isn't good :)). Docker's install script gets around this with:

# wrapped up in a function so that we have some protection against only getting
# half the file during "curl | sh"
do_install

We probably should add something similar :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants