Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook errors when loading Galaxy which requires login #19686

Open
martenson opened this issue Feb 24, 2025 · 2 comments
Open

webhook errors when loading Galaxy which requires login #19686

martenson opened this issue Feb 24, 2025 · 2 comments

Comments

@martenson
Copy link
Member

If you first load a Galaxy that requires login (like usegalaxy.no [23.2] or usegalaxy.cz[24.2]) you will see the following in the browser console:

analysis.bundled.js?v=1733160056000:2 Uncaught (in promise) TypeError: e.filter is not a function
    at analysis.bundled.js?v=1733160056000:2:3831720
    at u (analysis.bundled.js?v=1733160056000:2:3831779)
    at analysis.bundled.js?v=1733160056000:2:3832422

or with sourcemaps:

webhooks.js:62 Uncaught (in promise) TypeError: e.filter is not a function
    at webhooks.js:62:17
    at d (webhooks.js:50:24)
    at webhooks.js:57:26

I assume some webhooks are trying to load improperly. the usegalaxy.cz has no webhooks enabled afaik.

@dannon
Copy link
Member

dannon commented Feb 24, 2025

@martenson I see what's going on here, thanks for the report. The problem is that with login being required, that API request is getting sent back as a 302 to the login page contents, which isn't the json blob expected, and of course fails to parse. I can make the parsing more robust here, which is part of a fix. The other bit will be that while the API should be accessible anonymously, and I can query it directly w/ curl, it looks like requests that actually send a session hit the redirect which we almost certainly don't want for valid anonymous_and_sessionless endpoints.

@dannon dannon self-assigned this Feb 25, 2025
@dannon
Copy link
Member

dannon commented Feb 25, 2025

Taking the opportunity to de-backbone our webhooks and make this more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants