Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review comments: HTML and inline css styles are not escaped #2851

Open
scotthallock opened this issue Mar 23, 2023 · 0 comments
Open

Code review comments: HTML and inline css styles are not escaped #2851

scotthallock opened this issue Mar 23, 2023 · 0 comments
Labels
research

Comments

@scotthallock
Copy link
Collaborator

Inline styles

A user can create comments that contain HTML elements and inline css styles:

Screenshot 2023-03-23 at 3 58 29 PM

Screenshot 2023-03-23 at 3 58 49 PM

<script>

A comment can include a <script> tag. However, initial tests show that the script will not run:

Screenshot 2023-03-23 at 4 18 17 PM

Screenshot 2023-03-23 at 4 18 37 PM

Expected behavior:

  • Should only standard markdown be supported for code review comments?
  • Should a user be allowed to create HTML elements and use inline styles?
@scotthallock scotthallock changed the title Code review comments: HTML elements and inline css styles are not escaped Code review comments: HTML and inline css styles are not escaped Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
research
Projects
C0D3-APP Team Sprints
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flacial @scotthallock