Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random enchants #740

Open
Gorecore666 opened this issue Jun 29, 2022 · 3 comments
Open

Random enchants #740

Gorecore666 opened this issue Jun 29, 2022 · 3 comments
Labels
area/misc Issues that don't fit particularly well into any other areas. blocked/feedback Awaiting feedback or input from community. type/enhancement New or improved feature.

Comments

@Gorecore666
Copy link

Gorecore666 commented Jun 29, 2022

Feature request

Short description

I would like to have a way to add random enchants to certain or all waves.

Implementation details

If possible, and i think it is, i would suggest making it to where you can add random enchants to weapons and armor. Even if it is only on certain waves like upgrade, boss and reward waves. I feel it would make setting up the waves much easier than having to make pools. Also it would be cool to be able to use the "thing" variables "random" and "all" to the upgrade waves.

Random enchant sample
upgrade1:
type: upgrade
upgrades:
all: iron_chestplate enchant_randomly:1, iron_sword enchant_randomly:2

<item> <ench>:<lvl>, <item> <ench>:<lvl>

example for grouping and randomization in upgrade wave:

upgrade1:
type:upgrade
upgrades:
all: all( random(<item>, <item>), <item>)

Additional info

@garbagemule
Copy link
Owner

Hi. Please edit your post so that it follows the feature request template. Thanks.

@garbagemule garbagemule added the blocked/invalid Awaiting adjustments to comply with template. label Jun 29, 2022
@Gorecore666
Copy link
Author

I hope that is better, sorry about that.

@garbagemule
Copy link
Owner

I think adding an element of randomization to any sort of configuration has the potential to make it more interesting, but I have two problems with the proposed feature:

  • People generally don't like "real" randomness. Or at least, they usually want a bit more flexibility than a uniform distribution over a set that they can't control. So in this case, you'd actually get a random enchant, not just one of three different enchants. That is very, very likely to be a follow-up request. Especially since not all enchants work on all items, so some sort of filtering is necessary.
  • I think random enchants are an oddly specific use case. Like why is it specifically enchants that should be randomizable? Why not item amounts? Or item data values (like wool color)?

That last point is perhaps a good segue into the idea of flexible item configuration via item specifications that can be configured and referenced. This leads to some of the same points I've addressed in this comment: #212 (comment)

Perhaps we could merge this issue with #212, but include a comment about more flexible "selectors" of sorts? Or at least expand upon this issue so that it doesn't just pertain to enchants, and so that it allows for some configuration.

@garbagemule garbagemule added type/enhancement New or improved feature. blocked/feedback Awaiting feedback or input from community. area/misc Issues that don't fit particularly well into any other areas. and removed blocked/invalid Awaiting adjustments to comply with template. labels Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/misc Issues that don't fit particularly well into any other areas. blocked/feedback Awaiting feedback or input from community. type/enhancement New or improved feature.
Projects
None yet
Development

No branches or pull requests

2 participants