Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Create" forms by custom forms in certain scenarios #21

Open
porduna opened this issue Mar 25, 2013 · 2 comments
Open

Replace "Create" forms by custom forms in certain scenarios #21

porduna opened this issue Mar 25, 2013 · 2 comments

Comments

@porduna
Copy link
Member

porduna commented Mar 25, 2013

The UI of the admin panel for adding credentials is not very intuitive. If you select "Basic", it still requests "key" and "secret", instead of something like "username" and "password" or so. Maybe we should have custom forms for this type of stuff (or different tables, whatever is easier to maintain).

For instance, in WebLab-Deusto we use the default "Create" with small customizations (hashing, etc.), but for permissions we created new forms from scratch. You can see them here.

In the same way, I did some tricks when adding a new ReLMS which I'm not comfortable with, since it is strongly coupled with the internal implementation of wtforms. Using different panels would be easier, and it would not require changing the API.

@nhocki
Copy link
Member

nhocki commented Mar 25, 2013

Yes. We need two things:

  1. Display shared & secret keys for OAuth credentials.
  2. Change the texts for Basic Auth.

I do not mind the coupling to WTForm right now. I think making a wrapper around that (Issue #10) is great but not essential at this point.

@porduna
Copy link
Member Author

porduna commented Mar 25, 2013

Yes, I'm not worried with being coupled to wtforms at this stage (we're using it anyway). If we're using its public interface, that's fine. But in the ReLMS creation panel, I check the HTML generated by it, generate a replacements so as to refresh the website when selecting one option or another. And this might even be too complicated for inline models.

That's why I would like to replace the whole "Create" panel in the case of ReLMS and LMSs. I would simply add a can_create = False and then provide custom forms for each thing. And since this would be a "native feature", it is not in conflict with #10 (which is thought for third party plug-ins).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants