Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build demo through GitHub CI #55

Open
mondeja opened this issue Mar 11, 2024 · 4 comments
Open

Build demo through GitHub CI #55

mondeja opened this issue Mar 11, 2024 · 4 comments
Labels
chore Internal things like configuring checks or minor updates

Comments

@mondeja
Copy link
Collaborator

mondeja commented Mar 11, 2024

I'm seeing that you're building the Vercel APP demo manually or with an external workflow. This surely is tedious and cause isn't automated.

Vercel can be configured to build the demo with GitHub Actions. Your VERCEL_TOKEN will be safe using action secrets. See https://vercel.com/guides/how-can-i-use-github-actions-with-vercel

@mondeja mondeja added the chore Internal things like configuring checks or minor updates label Mar 11, 2024
@friendlymatthew
Copy link
Member

I'm seeing that you're building the Vercel APP demo manually or with an external workflow. This surely is tedious and cause isn't automated.

Yeah, FWIW the demo seems to rebuild upon a new commit on main

@mondeja
Copy link
Collaborator Author

mondeja commented Mar 11, 2024

Yeah, FWIW the demo seems to rebuild upon a new commit on main

That's probably something that we don't want, seems a bit risky and is preferable to be updated on releases to reflect new features, but for now is OK.

@friendlymatthew
Copy link
Member

@all-contributors
please add @mondeja for code.
please add @JustBobinAround for code.

Copy link
Contributor

@friendlymatthew

I've put up a pull request to add @mondeja! 🎉

I've put up a pull request to add @JustBobinAround! 🎉

@mondeja mondeja mentioned this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Internal things like configuring checks or minor updates
Projects
None yet
Development

No branches or pull requests

2 participants