Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign_remotery_vis script prevents side-by-side installation of common3, common4 #167

Closed
scpeters opened this issue Feb 5, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@scpeters
Copy link
Member

scpeters commented Feb 5, 2021

The ign_remotery_vis script is installed to <prefix>/bin with no major version name, which causes a conflict between ign-common3 and ign-common4. I expect this will be a problem with side-by-side install of the debs, but I first noticed it with homebrew bottles in osrf/homebrew-simulation#1324:

==> Pouring ignition-common4-3.999.999~0~20210125~260e23.mojave.bottle.tar.gz
The formula built, but is not symlinked into /usr/local
Error: The `brew link` step did not complete successfully
Could not symlink bin/ign_remotery_vis
Target /usr/local/bin/ign_remotery_vis
is a symlink belonging to ignition-common3.
@scpeters scpeters added the bug Something isn't working label Feb 5, 2021
@chapulina
Copy link
Contributor

We could append the version number to the executable starting from v4.

@scpeters
Copy link
Member Author

scpeters commented Feb 6, 2021

should it be part of an ign command? ign remotery --vis?

@chapulina
Copy link
Contributor

Yeah that's an option. It adds a dependency, but I think it's worth it. I'd suggest something like ign profiler remotery --vis though, in case we support other profilers in the future.

@mjcarroll
Copy link
Contributor

Going to use this as an opportunity to fix #82 as well.

In terms of using it with ign, we can probably install/register it in such a way that there isn't a direct dependency on ign-tools, but will work if ign-tools is installed.

@chapulina
Copy link
Contributor

I believe this has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants