Add pybindings for VolumetricGridLookupField #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gokulp01 <[email protected]>
Signed-off-by: gokulp01 <[email protected]>
Signed-off-by: gokulp01 <[email protected]>
Signed-off-by: gokulp01 <[email protected]>
|
Hi @scpeters / @adityapande-1995 / @ahcorde, just wanted to follow up on this (: If there’s anything more needed from my end, I’d be happy to address it! Thanks for your time and guidance. |
ahcorde
requested changes
Jan 14, 2025
Signed-off-by: gokulp01 <[email protected]>
|
Hi @ahcorde thank you for the review! I’ve addressed your feedback. Let me know if there’s anything else to update. Thanks! |
ahcorde
requested changes
Jan 15, 2025
| using Class = gz::math::VolumetricGridLookupField<T, I>; | ||
| using Vector3Type = gz::math::Vector3<T>; | ||
|
|
||
| auto toString = [](const Class &si) { |
|
|
||
| auto toString = [](const Class &si) { | ||
| std::stringstream stream; | ||
| stream << "VolumetricGridLookupField"; |
There was a problem hiding this comment.
Suggested change
| stream << "VolumetricGridLookupField"; | |
| stream << si; |
There was a problem hiding this comment.
this doesn't work because VolumetricGridLookupField doesn't overload the << operator
There was a problem hiding this comment.
from a brief inspection, classes that don't overload << also don't define a python method for __str__, so I think you could omit it for VolumetricGridLookupField
example:
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Gokul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Closes #477
Summary
This pull request adds Python bindings for
VolumetricGridLookupField, enabling its usage in Python.Changes:
CMakeLists.txtto build the new Python bindingsInterpolationPointpybindings, which are dependencies forVolumetricGridLookupFieldVolumetricGridLookupFieldDetails:
src/python_pybind11/CMakeLists.txt: Modified to include new files in the buildsrc/python_pybind11/src/_gz_math_pybind11.cc: Updated to include headers for the bindingssrc/python_pybind11/src/InterpolationPoint.ccand.hh: Provide pybindings forInterpolationPointsrc/python_pybind11/src/VolumetricGridLookupField.ccand.hh: Implement pybindings forVolumetricGridLookupFieldsrc/python_pybind11/test/VolumetricGridLookupField_TEST.py: Test file for validating the functionalityTest it
Build the project and test the bindings with
Expected Result:
VolumetricGridLookupFieldbindings should function correctly in Python.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.