Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] In /src/App.js useStyles / makeStyles is depr. #3

Open
gbowne1 opened this issue Jun 21, 2023 · 12 comments
Open

[BUG] In /src/App.js useStyles / makeStyles is depr. #3

gbowne1 opened this issue Jun 21, 2023 · 12 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Jun 21, 2023

Description

useStyles & makeStyles is deprecated in @mui 5

Remove this styling and add .css files instead.

Screenshots

No response

@gbowne1 gbowne1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Jun 21, 2023
@gbowne1 gbowne1 moved this to In Progress in SPMS_ERP_MRPUpdatedRepo Jun 21, 2023
@gbowne1 gbowne1 moved this from In Progress to Todo in SPMS_ERP_MRPUpdatedRepo Jun 21, 2023
@itspunkaj
Copy link
Contributor

hey did you try using migration to tss-react

@itspunkaj
Copy link
Contributor

i think i can help in this. Let me know the how to contribute.

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 21, 2023

The styling could be moved to App.css instead. I don't even know what tss-react is. I am using MUI here.

I wanted to make compoment css for Drawer and the navigation.

If you want to work on it, go ahead.

@itspunkaj
Copy link
Contributor

you just want the makestyles css to work right ???

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 21, 2023

It's deprecated.. it can just be removed. @mui/styles and @mui/material/styles are both deprecated, so they won't work.

The styling should ideally be moved to individual CSS files. These ones were for the Drawer component and the top navbar, exported from MUI as AppBar, Toolbar...

https://mui.com/material-ui/react-app-bar/https://mui.com/material-ui/react-app-bar/
https://mui.com/material-ui/react-drawer/

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 21, 2023

if you think tss-react could fix it, I am open to options here.

@itspunkaj
Copy link
Contributor

hey i have solved the issue of makeStyles but now it shows some useContext issue. Was it already there ??

@itspunkaj
Copy link
Contributor

@gbowne1

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 22, 2023

Not that I know of @itspunkaj . Feel free to PR what you have.

@itspunkaj
Copy link
Contributor

um lemme check it i'll PR in hour or so

@gbowne1
Copy link
Owner Author

gbowne1 commented Jun 22, 2023

No rush. Am not at my PC rn. I can review when I get back. I need to add the TÒDO issues today as well as there are missing some of the pages and their components.

@itspunkaj
Copy link
Contributor

okay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
Development

No branches or pull requests

2 participants