Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact page (contact.html) #67

Open
3 of 5 tasks
gbowne1 opened this issue Aug 24, 2022 · 13 comments
Open
3 of 5 tasks

Contact page (contact.html) #67

gbowne1 opened this issue Aug 24, 2022 · 13 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Aug 24, 2022

Prerequisites

Current Behavior

  • Navbar is messed up completely.

  • Container for the Map overflows
    <div class="container z-depth-1 my-5 px-0" style="background-color:rgb(228, 106, 218)">

  • Header container overflows

  • <header>
    <div class="container>' [overflow]

  • Footer overflows @ <footer class="footer-wrapper

  • Footer missing Instagram and YouTube social icons

  • Google Maps should be a small or medium element inside the footer, not a large frame inside the main body.

  • Phone Contact Field is wrong type for a phone number and should just say Phone

  • Add field for Mobile Phone

  • Missing the theme switch that is now on the About page (about.html)
    (consider adding a theme.css). The theme should propagate through the rest of the site no matter what page you are on.

Content Security Policy: Ignoring “http:” within script-src: ‘strict-dynamic’ specified warning in the console.. which might be coming from Google Maps API.

  • Footer needs Business hours

  • Remove MDBootstrap branding

Good theme colors are:
#0000ff blue
#000000 black
#808080 gray
#ffffff white
#c0c0c0 silver
{ maybe even brown }

Background where possible should be a gray/silver metallic brush finish

Expected Behavior

  • Working nav
  • Correct theme

Steps to Reproduce

Try it! :-)

@gbowne1 gbowne1 added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Aug 24, 2022
@gbowne1 gbowne1 added this to the Website Frontend milestone Aug 25, 2022
@gbowne1 gbowne1 moved this to Todo in SPMS Site Template Aug 25, 2022
@Traceydh
Copy link
Collaborator

Hello I would like to give this a try, can you assign it to me? :)

@gbowne1
Copy link
Owner Author

gbowne1 commented Aug 26, 2022

Ok @Traceydh

@gbowne1
Copy link
Owner Author

gbowne1 commented Aug 27, 2022

This is also missing an "How did you find us?" field

@Traceydh
Copy link
Collaborator

Ok sure I'll add a 'how did you find us' field in the form.

@gbowne1
Copy link
Owner Author

gbowne1 commented Aug 27, 2022

Thanks! 👍 :-)

@Traceydh
Copy link
Collaborator

Hey, this might be an obvious question but I'm kinda new to this.
When I opened the project in chrome I can see that _navbar.scss is styling the contact page. However, looking through the folder I downloaded from github I can only see styles.css.
From googling I understand that _navbar.scss is a SASS file (from Ruby), how do I access and edit this file? I can't make meaningful changes via only editing styles.css.

@gbowne1
Copy link
Owner Author

gbowne1 commented Aug 28, 2022

Yes, no worries at all. As for the styles, there is only styles.css

The stylesheet link in the contact.html page is <link rel="stylesheet" href="../src/css/styles.css" /> and normally Bootstrap 5 CDN (Content Delivery Network) sends out its styles via the CDN links in the head tag, which are all scss.. this includes "_navbar.scss" and those files are not editable.

The file you should edit is styles.css in your IDE/Editor.

Thanks!

@Traceydh
Copy link
Collaborator

I see, that makes sense thanks!

@gbowne1
Copy link
Owner Author

gbowne1 commented Aug 30, 2022

@Traceydh

No worries. you're welcome.

@tejask1730
Copy link
Contributor

hello i want to resolve this issue pls can you guide?

@gbowne1
Copy link
Owner Author

gbowne1 commented Sep 27, 2022

@tejask1730 are you a student or just learning?

@tejask1730
Copy link
Contributor

tejask1730 commented Sep 28, 2022 via email

@gbowne1
Copy link
Owner Author

gbowne1 commented Sep 28, 2022

Ok @tejask1730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
Development

No branches or pull requests

3 participants