Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current index.html issues #75

Open
3 of 6 tasks
gbowne1 opened this issue Aug 27, 2022 · 1 comment
Open
3 of 6 tasks

Current index.html issues #75

gbowne1 opened this issue Aug 27, 2022 · 1 comment

Comments

@gbowne1
Copy link
Owner

gbowne1 commented Aug 27, 2022

⁰### Prerequisites

Current Behavior

[UpdatedJan 1st, 2023]

Here are the elements that overflow:

  • index.html Overflows
  • Body @
  • Header @
  • Footer @ <footer class="footer-wrapper">
  • Article @ both <h3> and <p>
  • Aside overflows
  • Section @ top level
  • Nav
    All <li> elements overflow inside the <ul>
    <a class="navbar-brand" href="./index.html">Home</a>
  • Search bar form element overflows

Needs a logo placeholder image. My old SPMS logo is proprietary. There are lorem ipsum placeholder images good for replacements at https://logoipsum.com/ that are free to use.

Favicon.ico 404's in console and is not loading.

Most of the current overflow issues may only be in Firefox. I use Firefox for Linux v104.0

This page needs a meta description defined for good SEO. It is currently blank.

  • #128
    They also need text labels. They also could be slightly larger for visibility and ease of use in mobile view.

  • #127

Site still not responsive. Dropdown still does not work. Referenced in another issue.

Expected Behavior

  • Elements do not overflow, etc.

Steps to Reproduce

Test in Chrome and Firefox and with Google Chrome Lighthouse in DevTools.

@gbowne1 gbowne1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Aug 27, 2022
@gbowne1 gbowne1 added this to the Website Frontend milestone Aug 27, 2022
@gbowne1 gbowne1 moved this to Todo in SPMS Site Template Aug 27, 2022
@gbowne1
Copy link
Owner Author

gbowne1 commented Aug 30, 2022

CDN's were fixed to include updated versions as well as include the missing CDN's for CSS and JavaScript for Bootstrap an FontAwesome and Popper.js

@gbowne1 gbowne1 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested and removed bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Sep 4, 2022
@gbowne1 gbowne1 removed bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant