Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gafferpy seed matching backwards compatibility #7

Open
t92549 opened this issue Aug 3, 2022 · 3 comments
Open

gafferpy seed matching backwards compatibility #7

t92549 opened this issue Aug 3, 2022 · 3 comments

Comments

@t92549
Copy link
Contributor

t92549 commented Aug 3, 2022

Gaffer 2 removed seed matching, but gafferpy could retain backwards compatibility with existing scripts by adding this back and translating the json to use Views instead.
@t92549
Copy link
Contributor Author

t92549 commented Aug 10, 2022

This could be done with **kwargs and the Operation base class

@t92549
Copy link
Contributor Author

t92549 commented Oct 17, 2022

SeedMatching was only used in GetElements and GetElementsBetweenSets so it could also be used in just those

@t92549
Copy link
Contributor Author

t92549 commented Oct 17, 2022

This can only be done in operations when there is no View provided and when the user provides elements rather than seeds. This is because the group is needed to put into the View.

@t92549 t92549 transferred this issue from gchq/gaffer-tools Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@t92549