Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BarChart should maintain the original order of rows #31

Open
gcdev373 opened this issue Feb 14, 2019 · 4 comments
Open

BarChart should maintain the original order of rows #31

gcdev373 opened this issue Feb 14, 2019 · 4 comments
Labels
bug

Comments

@gcdev373
Copy link
Member

It is already possible to flexibly sort data within the table. This is more powerful than sorting internally within the visualisation. Eg Sort might use a column that isn't even used by the chart.

Therefore, the original order of rows from the table should be preserved, rather than sorting the data internally (eg alphabetically in that case of string values).
@at055612
Copy link
Member

The problem lies in computeUniqueValues in common.js. It is using a hashmap to determine the unique set of values (for use in grid/legend logic). Needs to be changed to compute the unique set whilst preserving the order.

@at055612 at055612 added the bug label Feb 20, 2019
@at055612
Copy link
Member

A similar problem exists in computeUniqueKeys which follows similar logic.

at055612 added a commit that referenced this issue Feb 20, 2019
@at055612
gh-31 Change computeUnique(Keys|Values) to not sort unless specified
30cb8dc
at055612 added a commit that referenced this issue Feb 20, 2019
@at055612
Merge branch 'master' into gh-31-stop-sorting-unique-keys-and-values
60b464f
@at055612 at055612 mentioned this issue Feb 20, 2019
Merged
at055612 added a commit that referenced this issue Feb 20, 2019
@at055612
Merge pull request #36 from gchq/gh-31-stop-sorting-unique-keys-and-v…
8005158 
…alues

Gh 31 stop sorting unique keys and values
@at055612 at055612 reopened this Feb 20, 2019
@at055612
Copy link
Member

fixed in > v3.1.0

@at055612 at055612 reopened this Feb 20, 2019
@at055612
Copy link
Member

The fix resolves the issue on the viz side, but stroom is sending a sort direction of Ascending when none is set. See gchq/stroom#1100

at055612 added a commit that referenced this issue Feb 20, 2019
@at055612
gh-31 Fix incorect sort direction logic in computeUniqueValues
44d2da2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@at055612 @gcdev373