Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File view is slow (slower than same file's blame view) #57

Open
GoogleCodeExporter opened this issue Oct 21, 2015 · 6 comments
Open

File view is slow (slower than same file's blame view) #57

GoogleCodeExporter opened this issue Oct 21, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Load 
https://chromium.googlesource.com/chromium/src/+/master/build/common.gypi
2. Load 
https://chromium.googlesource.com/chromium/src/+blame/master/build/common.gypi

What is the expected output? What do you see instead?
1 should be no slower than 2. 1 is slower than 2.

Original issue reported on code.google.com by [email protected] on 18 Jun 2014 at 11:32

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 18 Jun 2014 at 11:33

  • Changed state: Duplicate

@GoogleCodeExporter
Copy link
Author

log view and file view are different, but ok...

Also, note that the blame view contains everything shown in the file view 
(which is not the case for log view).

Original comment by [email protected] on 18 Jun 2014 at 11:37

@GoogleCodeExporter
Copy link
Author

Misread your URLs, sorry. I can't reproduce the slowness with (1) though. There 
are various layers of caching involved, maybe you got unlucky?

Original comment by [email protected] on 18 Jun 2014 at 11:52

  • Changed state: New

@GoogleCodeExporter
Copy link
Author

Slower to me as well (i.e. the bug looks valid from here).

Original comment by [email protected] on 19 Jun 2014 at 2:21

@GoogleCodeExporter
Copy link
Author

Dave, are logs kept showing the performance of each request?  Can you verify 
whether Chris's request in (1) was slower than (2)?  As for which layer of 
caching is involved, is there enough data in the log to show why he may have 
been unlucky?

Original comment by [email protected] on 19 Jun 2014 at 11:08

@GoogleCodeExporter
Copy link
Author

Erk, in issue 56, issue 57 was merged as duplicate.  However, the view of issue 
57 is still "New" and mergedinto is blank.

Original comment by [email protected] on 19 Jun 2014 at 11:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant