Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to remove the world parameter from the constructor of basesystem? #27

Open
Shadowblitz16 opened this issue Oct 2, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@Shadowblitz16
Copy link

It would be nice if we didn't need to define a constructor when inheriting BaseSystem

@genaray genaray added the enhancement New feature or request label Oct 3, 2023
@genaray
Copy link
Owner

genaray commented Oct 3, 2023

Do you mean in the source-gen or just the basic BaseSystem? ^^
Its possible of course, can add that fairly easy :)

@Shadowblitz16
Copy link
Author

Do you mean in the source-gen or just the basic BaseSystem? ^^ Its possible of course, can add that fairly easy :)

I mean in the BaseSystem.

Internally passing it to BaseSystem when it's created was what I was thinking

@genaray
Copy link
Owner

genaray commented Oct 8, 2023

Do you mean in the source-gen or just the basic BaseSystem? ^^ Its possible of course, can add that fairly easy :)

I mean in the BaseSystem.

Internally passing it to BaseSystem when it's created was what I was thinking

Im just looking at it.
I could make the World property public and add a empty ctor.
This way one could create a basesystem without a world and set the world afterwards.

Would this be enough?

@Shadowblitz16
Copy link
Author

This would probably be enough I am trying to make a very simple, fast and safe wrapper around arch so this would probably do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants