Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation Preview lists additional "enabled by GENEPRODUCT" in extensions #534

Open
suzialeksander opened this issue Nov 28, 2023 · 5 comments

Comments

@suzialeksander
Copy link

suzialeksander commented Nov 28, 2023

Some of the imported SGD YeastPathways have additional entities in the extensions. In gomodel:YeastPathways_TREDEG-YEAST-PWY, there is an annotation to ATH1 but there's a loose enabled_by(NTH1 Scer) in the extensions, and vice versa. This might have something to do with branched/cyclical pathways.
Screenshot 2023-11-28 at 13 21 08

Additional oddity: ATH1 and NTH1 appear in GE, Alliance Pathway Preview. Visual Pathway Editor doesn't mention NTH1.

tagging @dustine32

@dustine32
Copy link
Contributor

Here's the whole model on Noctua prod:
image
You can see each of the two enabled_by annotations (ATH1, NTH1) reflecting each other in their extensions fields.

Maybe a simple fix is to disallow enabled_by from being emitted in the GPAD export extensions column?

@dustine32
Copy link
Contributor

dustine32 commented Nov 29, 2023

@balhoff If we wanted to remove enabled_by relations from Noctua GPAD export extensions column is this the line we'd need to take out?

Also tagging @vanaukenk @pgaudet as I feel this is executive decision-level stuff.

@pgaudet
Copy link

pgaudet commented Nov 29, 2023

Discussion on the managers call:

There should not be 2 enablers, this violates ShEx.

Options to fix this would be

  • to create two separate models, one for each enabler,
  • or two individuals in the same model

If the model is fixed, then there will not be exported in the extensions.

Pascale

@suzialeksander
Copy link
Author

note, i've manually fixed the model above. SGD is going to proceed to manually edit these models in Noctua production.

@suzialeksander
Copy link
Author

Screenshot 2023-11-29 at 10 47 48

For the above model, the error is

Violations
This feature is currently under development, with more user friendly error reports coming. If you have questions about the error messages you're seeing, please create a [ticket](https://github.com/geneontology/noctua).
[
   {
      "shape": "obo:go/shapes/MolecularFunction",
      "constraints": [
         {
            "property": "RO:0002333",
            "cardinality": "[0; 1]",
            "nobjects": 2
         }
      ]
   }
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants