Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary dependencies #274

Open
jpfeuffer opened this issue Aug 29, 2020 · 0 comments
Open

Remove unnecessary dependencies #274

jpfeuffer opened this issue Aug 29, 2020 · 0 comments

Comments

@jpfeuffer
Copy link
Member

jpfeuffer commented Aug 29, 2020 •
edited
Loading

E.g. I recently removed apache.commons.text / apache.commons.lang3.text from IndexLoader since the methods are either deprecated or the packages are not shipped in the knime update site anymore.
Options:

  1. check how knime does it now
  2. think about if really needed (here: system property substitution in file paths) and remove/comment out (currently done). Commit 8a7955c and related
  3. write your own
  4. use/inherit from knime classes properly or ask for an API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpfeuffer