Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check hook + genesis config block #17

Open
daviddob opened this issue May 21, 2020 · 1 comment
Open

Check hook + genesis config block #17

daviddob opened this issue May 21, 2020 · 1 comment
Assignees
@dennisjbell @mrferris
Labels
PRIORITY: Low-hanging Fruit Small bug or enhancement, easily resolved TRIAGE: Accepted Ticket has been accepted for work to proceed TYPE: Bug Defect in intended behaviour

Comments

@daviddob
Copy link
Contributor

Check hook doesn't fail deployment with missing values - continues without failing

Also the new hook doesnt use the genesis-config-block
@dennisjbell
Copy link
Member

Yes, the check script is broken. After checking, it just sets check to okay, then if its okay, states the environment is ok.

https://github.com/genesis-community/prometheus-genesis-kit/blame/master/hooks/check#L11-L13

@dennisjbell dennisjbell added TRIAGE: Accepted Ticket has been accepted for work to proceed TYPE: Bug Defect in intended behaviour PRIORITY: Low-hanging Fruit Small bug or enhancement, easily resolved labels Feb 11, 2021
@dennisjbell dennisjbell mentioned this issue Feb 11, 2021
Closed
@ramonskie ramonskie self-assigned this Feb 17, 2021
@mrferris mrferris reopened this Aug 2, 2021
@mrferris mrferris assigned dennisjbell and mrferris and unassigned ramonskie Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dennisjbell dennisjbell

@mrferris mrferris

Labels
PRIORITY: Low-hanging Fruit Small bug or enhancement, easily resolved TRIAGE: Accepted Ticket has been accepted for work to proceed TYPE: Bug Defect in intended behaviour
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dennisjbell @ramonskie @mrferris @daviddob