Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ add server to serve API endpoints for interaction wi… #23

Merged
merged 127 commits into from
Apr 15, 2024

Conversation

sourabhxyz
Copy link
Member

…th GeniusYield DEX

Closes: #21

… atlas commit to use enhanced swagger instances.

Closes: #21
…tlas commit which now has improved instances and some helper utilities
@sourabhxyz sourabhxyz marked this pull request as ready for review April 3, 2024 10:11
@sourabhxyz sourabhxyz requested a review from a team as a code owner April 3, 2024 10:11
@sourabhxyz sourabhxyz marked this pull request as draft April 3, 2024 10:12
@sourabhxyz sourabhxyz marked this pull request as ready for review April 3, 2024 10:25
response500 ∷ Response
response500 = mempty & description .~ "Internal server error"

-- response500SigningKeyFailure ∷ Response
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you wanted to delete lines 101 - 104.

Dockerfile Outdated
ENV LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH"
ENV PKG_CONFIG_PATH="/usr/local/lib/pkgconfig:$PKG_CONFIG_PATH"

# Install ghcup using official command from https://www.haskell.org/ghcup/. Following stackoverflow discussion had been helpful in regards to GHC installation https://stackoverflow.com/q/67680726/20330802.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Install ghcup using official command from https://www.haskell.org/ghcup/. Following stackoverflow discussion had been helpful in regards to GHC installation https://stackoverflow.com/q/67680726/20330802.
# Install ghcup:

Dockerfile Outdated
ENV BOOTSTRAP_HASKELL_NONINTERACTIVE=1
RUN bash -c "curl --proto '=https' --tlsv1.2 -sSf https://get-ghcup.haskell.org | sh"

# Add ghcup to PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Add ghcup to PATH

Dockerfile Outdated
ENV PATH=${PATH}:/root/.local/bin
ENV PATH=${PATH}:/root/.ghcup/bin

# Install specific versions of GHC and Cabal and set them.
Copy link
Contributor

@4TT1L4 4TT1L4 Apr 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Install specific versions of GHC and Cabal and set them.
# Install GHC and Cabal:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to omit this comment? GHCup pre installs some GHC & Cabal version and we want to install other and set them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is obvious what is happening. No need to repeat everything in the comments.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, but your suggestion is misleading, we already have GHC & cabal installed but want to install specific version of those and set them. I'd prefer no comment over incorrect one.

build(docker): Add GPG keys
Copy link
Member Author

@sourabhxyz sourabhxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@4TT1L4 Changes done in commit 7c176433b3f1cb96f440049784a63c80be71e4c5 would make it incompatible with apple silicon as you are downloading specific architecture binary here.

Copy link
Contributor

@4TT1L4 4TT1L4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some polishing is still needed, but we really need to get this to main now.

Let's do the further polishing via future pull requests.

@4TT1L4 4TT1L4 merged commit 983efd5 into main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot API server
3 participants