-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ✨ add server to serve API endpoints for interaction wi… #23
Conversation
response500 ∷ Response | ||
response500 = mempty & description .~ "Internal server error" | ||
|
||
-- response500SigningKeyFailure ∷ Response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess you wanted to delete lines 101 - 104.
Updates upon #21
Dockerfile
Outdated
ENV LD_LIBRARY_PATH="/usr/local/lib:$LD_LIBRARY_PATH" | ||
ENV PKG_CONFIG_PATH="/usr/local/lib/pkgconfig:$PKG_CONFIG_PATH" | ||
|
||
# Install ghcup using official command from https://www.haskell.org/ghcup/. Following stackoverflow discussion had been helpful in regards to GHC installation https://stackoverflow.com/q/67680726/20330802. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Install ghcup using official command from https://www.haskell.org/ghcup/. Following stackoverflow discussion had been helpful in regards to GHC installation https://stackoverflow.com/q/67680726/20330802. | |
# Install ghcup: |
Dockerfile
Outdated
ENV BOOTSTRAP_HASKELL_NONINTERACTIVE=1 | ||
RUN bash -c "curl --proto '=https' --tlsv1.2 -sSf https://get-ghcup.haskell.org | sh" | ||
|
||
# Add ghcup to PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Add ghcup to PATH |
Dockerfile
Outdated
ENV PATH=${PATH}:/root/.local/bin | ||
ENV PATH=${PATH}:/root/.ghcup/bin | ||
|
||
# Install specific versions of GHC and Cabal and set them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Install specific versions of GHC and Cabal and set them. | |
# Install GHC and Cabal: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you want to omit this comment? GHCup pre installs some GHC & Cabal version and we want to install other and set them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is obvious what is happening. No need to repeat everything in the comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, but your suggestion is misleading, we already have GHC & cabal installed but want to install specific version of those and set them. I'd prefer no comment over incorrect one.
build(docker): Add GPG keys
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@4TT1L4 Changes done in commit 7c176433b3f1cb96f440049784a63c80be71e4c5
would make it incompatible with apple silicon as you are downloading specific architecture binary here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some polishing is still needed, but we really need to get this to main now.
Let's do the further polishing via future pull requests.
…th GeniusYield DEX
Closes: #21